From cd130e45cb5599aef419bf8afd66b57ed9e6ef72 Mon Sep 17 00:00:00 2001 From: CrazyMax <1951866+crazy-max@users.noreply.github.com> Date: Thu, 12 Feb 2026 01:24:04 +0100 Subject: [PATCH] preserve port in GIT_AUTH_TOKEN host Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com> --- __tests__/context.test.ts | 46 +++++++++++++++++++++++++++++++++++++++ src/context.ts | 2 +- 2 files changed, 47 insertions(+), 1 deletion(-) diff --git a/__tests__/context.test.ts b/__tests__/context.test.ts index 52c8ec7..b0e5982 100644 --- a/__tests__/context.test.ts +++ b/__tests__/context.test.ts @@ -857,6 +857,52 @@ ANOTHER_SECRET=ANOTHER_SECRET_ENV`] ['BUILDX_NO_DEFAULT_ATTESTATIONS', '1'] ]) ], + [ + 35, + '0.13.1', + new Map([ + ['github-token', 'abcdefghijklmno0123456789'], + ['context', '{{defaultContext}}'], + ['load', 'false'], + ['no-cache', 'false'], + ['push', 'false'], + ['pull', 'false'], + ]), + [ + 'build', + '--iidfile', imageIDFilePath, + '--attest', `type=provenance,mode=min,inline-only=true,builder-id=http://10.0.0.5:22827/docker/build-push-action/actions/runs/123456789/attempts/1`, + '--secret', `id=GIT_AUTH_TOKEN.10.0.0.5:22827,src=${tmpName}`, + '--metadata-file', metadataJson, + 'http://10.0.0.5:22827/docker/build-push-action.git#refs/heads/master' + ], + new Map([ + ['GITHUB_SERVER_URL', 'http://10.0.0.5:22827'], + ]) + ], + [ + 36, + '0.13.1', + new Map([ + ['github-token', 'abcdefghijklmno0123456789'], + ['context', '{{defaultContext}}'], + ['load', 'false'], + ['no-cache', 'false'], + ['push', 'false'], + ['pull', 'false'], + ]), + [ + 'build', + '--iidfile', imageIDFilePath, + '--attest', `type=provenance,mode=min,inline-only=true,builder-id=https://github.cds.internal.unity3d.com/docker/build-push-action/actions/runs/123456789/attempts/1`, + '--secret', `id=GIT_AUTH_TOKEN.github.cds.internal.unity3d.com,src=${tmpName}`, + '--metadata-file', metadataJson, + 'https://github.cds.internal.unity3d.com/docker/build-push-action.git#refs/heads/master' + ], + new Map([ + ['GITHUB_SERVER_URL', 'https://github.cds.internal.unity3d.com'], + ]) + ], ])( '[%d] given %p with %p as inputs, returns %p', async (num: number, buildxVersion: string, inputs: Map, expected: Array, envs: Map | undefined) => { diff --git a/src/context.ts b/src/context.ts index 1960e43..bd31d66 100644 --- a/src/context.ts +++ b/src/context.ts @@ -183,7 +183,7 @@ async function getBuildArgs(inputs: Inputs, context: string, toolkit: Toolkit): } }); if (inputs['github-token'] && !Build.hasGitAuthTokenSecret(inputs.secrets) && context.startsWith(Context.gitContext())) { - args.push('--secret', Build.resolveSecretString(`GIT_AUTH_TOKEN.${new URL(GitHub.serverURL).hostname.trimEnd()}=${inputs['github-token']}`)); + args.push('--secret', Build.resolveSecretString(`GIT_AUTH_TOKEN.${new URL(GitHub.serverURL).host.trimEnd()}=${inputs['github-token']}`)); } if (inputs['shm-size']) { args.push('--shm-size', inputs['shm-size']);